Get rid of ESLint warnings in the build

Either by fixing them or by adding them to the long list of locally disabled ones, when fixing them is too complicated for now. May contain traces of formatting related nitpicks.
JulianKniephoff · May 23, 2024 · 5ee5694 · 5ee5694
1 parent e6d61ff
commit 5ee5694
Show file tree

Hide file tree

Showing 17 changed files with 88 additions and 99 deletions.
diff --git a/src/components/configuration/partials/wizard/NewThemeWizard.tsx b/src/components/configuration/partials/wizard/NewThemeWizard.tsx
@@ -10,7 +10,7 @@ import { initialFormValuesNewThemes } from "../../../../configs/modalConfig";
 import { usePageFunctions } from "../../../../hooks/wizardHooks";
 import { NewThemeSchema } from "../../../../utils/validate";
 import { useAppDispatch } from "../../../../store";
-import { Details, postNewTheme } from "../../../../slices/themeSlice";
+import { postNewTheme } from "../../../../slices/themeSlice";
 
 /**
  * This component manages the pages of the new theme wizard and the submission of values

diff --git a/src/components/events/partials/ModalTabsAndPages/DetailsMetadataTab.tsx b/src/components/events/partials/ModalTabsAndPages/DetailsMetadataTab.tsx
@@ -8,7 +8,7 @@ import RenderDate from "../../../shared/RenderDate";
 import RenderMultiField from "../../../shared/wizard/RenderMultiField";
 import RenderField from "../../../shared/wizard/RenderField";
 import { getUserInformation } from "../../../../selectors/userInfoSelectors";
-import { getCurrentLanguageInformation, hasAccess, isJson } from "../../../../utils/utils";
+import { hasAccess, isJson } from "../../../../utils/utils";
 import { getMetadataCollectionFieldName } from "../../../../utils/resourceUtils";
 import { useAppSelector } from "../../../../store";
 
@@ -31,8 +31,6 @@ const DetailsMetadataTab: React.FC<{
 	const { t } = useTranslation();
 
 	const user = useAppSelector(state => getUserInformation(state));
-	// Get info about the current language and its date locale
-	const currentLanguage = getCurrentLanguageInformation();
 
 // @ts-expect-error TS(7006): Parameter 'values' implicitly has an 'any' type.
 	const handleSubmit = (values) => {

diff --git a/src/components/events/partials/ModalTabsAndPages/EventDetailsAssetAttachmentDetails.tsx b/src/components/events/partials/ModalTabsAndPages/EventDetailsAssetAttachmentDetails.tsx
@@ -144,6 +144,7 @@ const EventDetailsAssetAttachmentDetails = ({
 												}
 											</td>
 											<td>
+												{/* eslint-disable-next-line jsx-a11y/anchor-has-content */}
 												<a
 													className="fa fa-external-link"
 													href={attachment.url}

diff --git a/src/components/events/partials/ModalTabsAndPages/EventDetailsAssetCatalogDetails.tsx b/src/components/events/partials/ModalTabsAndPages/EventDetailsAssetCatalogDetails.tsx
@@ -142,6 +142,7 @@ const EventDetailsAssetCatalogDetails = ({
 												}
 											</td>
 											<td>
+												{/* eslint-disable-next-line jsx-a11y/anchor-has-content */}
 												<a className="fa fa-external-link" href={catalog.url} />
 											</td>
 										</tr>

diff --git a/src/components/events/partials/ModalTabsAndPages/EventDetailsAssetPublicationDetails.tsx b/src/components/events/partials/ModalTabsAndPages/EventDetailsAssetPublicationDetails.tsx
@@ -144,6 +144,7 @@ const EventDetailsAssetPublicationDetails = ({
 												}
 											</td>
 											<td>
+												{/* eslint-disable-next-line jsx-a11y/anchor-has-content */}
 												<a
 													className="fa fa-external-link"
 													href={publication.url}

diff --git a/src/components/events/partials/ModalTabsAndPages/EventDetailsAssetsAddAsset.tsx b/src/components/events/partials/ModalTabsAndPages/EventDetailsAssetsAddAsset.tsx
@@ -90,8 +90,8 @@ const EventDetailsAssetsAddAsset = ({
 																{" "}
 																{translateOverrideFallback(asset, t)}
 																<span className="ui-helper-hidden">
-                                  { // eslint-disable-next-line react/jsx-no-comment-textnodes
-                                  } ({asset.type} "{asset.flavorType}//
+                                  {/* eslint-disable-next-line react/jsx-no-comment-textnodes */}
+                                  ({asset.type} "{asset.flavorType}//
 																	{asset.flavorSubType}")
 																</span>
 															</td>

diff --git a/src/components/events/partials/ModalTabsAndPages/EventDetailsPublicationTab.tsx b/src/components/events/partials/ModalTabsAndPages/EventDetailsPublicationTab.tsx
@@ -69,6 +69,7 @@ const EventDetailsPublicationTab = ({
 														</div>
 
 														{publication.enabled ? (
+															// eslint-disable-next-line jsx-a11y/anchor-has-content
 															<a className="play" href={publication.url} />
 														) : (
 															<span style={styleSpan}>

diff --git a/src/components/events/partials/ModalTabsAndPages/NewAssetUploadPage.tsx b/src/components/events/partials/ModalTabsAndPages/NewAssetUploadPage.tsx
@@ -70,8 +70,8 @@ const NewAssetUploadPage = <T extends RequiredFormProps>({
 														{" "}
 														{translateOverrideFallback(asset, t)}
 														<span className="ui-helper-hidden">
-                              { // eslint-disable-next-line react/jsx-no-comment-textnodes
-                              } ({asset.type} "{asset.flavorType}//
+                              {/* eslint-disable-next-line react/jsx-no-comment-textnodes */}
+                              ({asset.type} "{asset.flavorType}//
 															{asset.flavorSubType}")
 														</span>
 													</td>

diff --git a/src/components/events/partials/modals/StartTaskModal.tsx b/src/components/events/partials/modals/StartTaskModal.tsx
@@ -93,6 +93,7 @@ const StartTaskModal = ({
 						// eslint-disable-next-line react-hooks/rules-of-hooks
 						useEffect(() => {
 							formik.validateForm().then();
+						// eslint-disable-next-line react-hooks/exhaustive-deps
 						}, [page]);
 
 						return (

diff --git a/src/components/events/partials/wizards/NewEventSummary.tsx b/src/components/events/partials/wizards/NewEventSummary.tsx
@@ -133,8 +133,8 @@ const NewEventSummary = <T extends RequiredFormProps>({
 													<td>
 														{asset.translate}
 														<span className="ui-helper-hidden">
-                              { // eslint-disable-next-line react/jsx-no-comment-textnodes
-                              } ({asset.type} "{asset.flavorType}//
+                              {/* eslint-disable-next-line react/jsx-no-comment-textnodes */}
+                              ({asset.type} "{asset.flavorType}//
 															{asset.flavorSubType}")
 														</span>
 													</td>
@@ -165,8 +165,8 @@ const NewEventSummary = <T extends RequiredFormProps>({
 														<td>
 															{translateOverrideFallback(asset, t, "SHORT")}
 															<span className="ui-helper-hidden">
-                                { // eslint-disable-next-line react/jsx-no-comment-textnodes
-                                } ({asset.type} "{asset.flavorType}//
+                                {/* eslint-disable-next-line react/jsx-no-comment-textnodes */}
+                                ({asset.type} "{asset.flavorType}//
 																{asset.flavorSubType}")
 															</span>
 														</td>

diff --git a/src/components/shared/TableFilterProfiles.tsx b/src/components/shared/TableFilterProfiles.tsx
@@ -6,7 +6,6 @@ import { getFilterProfiles } from "../../selectors/tableFilterProfilesSelectors"
 import {
 	cancelEditFilterProfile,
 	createFilterProfile,
-	editFilterProfile,
 	removeFilterProfile,
 } from "../../slices/tableFilterProfilesSlice";
 import { getFilters } from "../../selectors/tableFilterSelectors";
@@ -43,7 +42,7 @@ const TableFiltersProfiles = ({
 	// State for helping saving and editing profiles
 	const [profileName, setProfileName] = useState("");
 	const [profileDescription, setProfileDescription] = useState("");
-	const [currentlyEditing, setCurrentlyEditing] = useState("");
+	const [, setCurrentlyEditing] = useState("");
 	const [validName, setValidName] = useState(false);
 
 	const { t } = useTranslation();

diff --git a/src/components/shared/TableFilters.tsx b/src/components/shared/TableFilters.tsx
@@ -1,4 +1,4 @@
-import React, { createRef, useRef, useState } from "react";
+import React, { useRef, useState } from "react";
 import { useTranslation } from "react-i18next";
 import { connect } from "react-redux";
 import { DatePicker } from "@mui/x-date-pickers/DatePicker";
@@ -307,41 +307,39 @@ const TableFilters = ({
 							{/* Show for each selected filter a blue label containing its name and option */}
 {/* @ts-expect-error TS(7006): Parameter 'filter' implicitly has an 'any' type. */}
 							{filterMap.map((filter, key) => {
-								if (!!filter.value) {
-									return (
-										<span className="ng-multi-value" key={key}>
-											<span>
-												{
-													// Use different representation of name and value depending on type of filter
-													filter.type === "select" ? (
-														renderBlueBox(filter)
-													) : filter.type === "period" ? (
+								return filter.value && (
+									<span className="ng-multi-value" key={key}>
+										<span>
+											{
+												// Use different representation of name and value depending on type of filter
+												filter.type === "select" ? (
+													renderBlueBox(filter)
+												) : filter.type === "period" ? (
+													<span>
 														<span>
-															<span>
-																{t(filter.label).substr(0, 40)}:
-																{t("dateFormats.date.short", {
-																	date: new Date(filter.value.split("/")[0]),
-																})}
-																-
-																{t("dateFormats.date.short", {
-																	date: new Date(filter.value.split("/")[1]),
-																})}
-															</span>
+															{t(filter.label).substr(0, 40)}:
+															{t("dateFormats.date.short", {
+																date: new Date(filter.value.split("/")[0]),
+															})}
+															-
+															{t("dateFormats.date.short", {
+																date: new Date(filter.value.split("/")[1]),
+															})}
 														</span>
-													) : null
-												}
-											</span>
-											{/* Remove icon in blue area around filter */}
-											<button
-												title={t("TABLE_FILTERS.REMOVE")}
-												onClick={() => removeFilter(filter)}
-                        className="button-like-anchor"
-											>
-												<i className="fa fa-times" />
-											</button>
+													</span>
+												) : null
+											}
 										</span>
-									);
-								}
+										{/* Remove icon in blue area around filter */}
+										<button
+											title={t("TABLE_FILTERS.REMOVE")}
+											onClick={() => removeFilter(filter)}
+											className="button-like-anchor"
+										>
+											<i className="fa fa-times" />
+										</button>
+									</span>
+								);
 							})}
 						</div>
 
@@ -525,7 +523,6 @@ const FilterSwitch = ({
     // This should never happen
     default:
       return null;
-
 	}
 };
 

diff --git a/src/components/shared/TimeSeriesStatistics.tsx b/src/components/shared/TimeSeriesStatistics.tsx
@@ -50,14 +50,6 @@ const TimeSeriesStatistics = ({
 // @ts-expect-error TS(7031): Binding element 'chartOptions' implicitly has an '... Remove this comment to see the full error message
 	chartOptions,
 }) => {
-	// Style for date picker
-	const datePickerStyle = {
-		border: "1px solid #dedddd",
-		borderRadius: "4px",
-		marginLeft: "3px",
-		marginRight: "5px",
-	};
-
 	// Style for radio buttons
 	const radioButtonStyle = {
 		backgroundColor: "whitesmoke",
@@ -212,6 +204,7 @@ const TimeSeriesStatistics = ({
 				<div className="statistics-graph">
 					{/* download link for a statistic file */}
 					<div className="download">
+						{/* eslint-disable-next-line jsx-a11y/anchor-has-content */}
 						<a
 							className="download-icon"
 							href={exportUrl}
@@ -265,6 +258,7 @@ const TimeSeriesStatistics = ({
 						formik.values.timeMode === "month") && (
 						/* year/month selection for statistic via previous and next buttons */
 						<span className="preset">
+							{/* eslint-disable-next-line jsx-a11y/anchor-has-content, jsx-a11y/anchor-is-valid */}
 							<a
 								className="navigation prev"
 								onClick={() =>
@@ -282,6 +276,7 @@ const TimeSeriesStatistics = ({
 									formik.values.timeMode
 								)}
 							</div>
+							{/* eslint-disable-next-line jsx-a11y/anchor-has-content, jsx-a11y/anchor-is-valid */}
 							<a
 								className="navigation next"
 								onClick={() =>

diff --git a/src/components/shared/wizard/RenderField.tsx b/src/components/shared/wizard/RenderField.tsx
@@ -183,49 +183,45 @@ const EditableDateValue = ({
 	showCheck,
 // @ts-expect-error TS(7031):
 	handleKeyDown
-}) => {
-	const { t } = useTranslation();
-
-	return editMode ? (
-		<div>
-			<DateTimePicker
-				name={field.name}
-				value={typeof field.value === "string" ? parseISO(field.value) : field.value}
-				onChange={(value) => setFieldValue(field.name, value)}
-				onClose={() => setEditMode(false)}
-				slotProps={{
-					textField: {
-						fullWidth: true,
-						onKeyDown: (event) => {
-							if (event.key === "Enter") {
-								handleKeyDown(event, "date")
-							}
-						},
-						onBlur: (event) => {
-							setEditMode(false)
+}) => editMode ? (
+	<div>
+		<DateTimePicker
+			name={field.name}
+			value={typeof field.value === "string" ? parseISO(field.value) : field.value}
+			onChange={(value) => setFieldValue(field.name, value)}
+			onClose={() => setEditMode(false)}
+			slotProps={{
+				textField: {
+					fullWidth: true,
+					onKeyDown: (event) => {
+						if (event.key === "Enter") {
+							handleKeyDown(event, "date")
 						}
+					},
+					onBlur: (event) => {
+						setEditMode(false)
 					}
-				}}
-			/>
-		</div>
-	) : (
-		<div onClick={() => setEditMode(true)} className="show-edit">
-			<span className="editable preserve-newlines">
-				<RenderDate date={text} />
-			</span>
-			<div>
-				<i className="edit fa fa-pencil-square" />
-				{showCheck && (
-					<i
-						className={cn("saved fa fa-check", {
-							active: initialValues[field.name] !== field.value,
-						})}
-					/>
-				)}
-			</div>
+				}
+			}}
+		/>
+	</div>
+) : (
+	<div onClick={() => setEditMode(true)} className="show-edit">
+		<span className="editable preserve-newlines">
+			<RenderDate date={text} />
+		</span>
+		<div>
+			<i className="edit fa fa-pencil-square" />
+			{showCheck && (
+				<i
+					className={cn("saved fa fa-check", {
+						active: initialValues[field.name] !== field.value,
+					})}
+				/>
+			)}
 		</div>
-	);
-};
+	</div>
+);
 
 // renders editable field for selecting value via dropdown
 const EditableSingleSelect = ({

diff --git a/src/components/shared/wizard/SelectContainer.tsx b/src/components/shared/wizard/SelectContainer.tsx
@@ -15,8 +15,7 @@ const SelectContainer = ({
 
 	// Formik hook for getting data of specific form field
 	// DON'T delete field and meta, hook works with indices not variable names
-	// eslint-disable-next-line no-unused-vars
-	const [field, meta, helpers] = useField(formikField);
+	const [field, , helpers] = useField(formikField);
 
 	// Search field for filter options/items
 	const [searchField, setSearchField] = useState("");

diff --git a/src/components/users/partials/wizard/NewUserWizard.tsx b/src/components/users/partials/wizard/NewUserWizard.tsx
@@ -72,6 +72,7 @@ const NewUserWizard = ({
 					// eslint-disable-next-line react-hooks/rules-of-hooks
 					useEffect(() => {
 						formik.validateForm();
+					// eslint-disable-next-line react-hooks/exhaustive-deps
 					}, [tab]);
 
 					return (

diff --git a/src/utils/bulkActionUtils.ts b/src/utils/bulkActionUtils.ts
@@ -1,7 +1,6 @@
 // Check if an event is scheduled and therefore editable
 import { hasDeviceAccess } from "./resourceUtils";
 import { NOTIFICATION_CONTEXT } from "../configs/modalConfig";
-import { useAppDispatch } from "../store";
 import { addNotification } from "../slices/notificationSlice";
 
 // Check if event is scheduled and therefore the schedule is editable
-Original file line number
+Diff line change
@@ Expand Up / @@ -144,6 +144,7 @@ const EventDetailsAssetAttachmentDetails = ({ @@
     												}
     											</td>
     											<td>
+    												{/* eslint-disable-next-line jsx-a11y/anchor-has-content */}
     												<a
     													className="fa fa-external-link"
     													href={attachment.url}
@@ Expand Down @@