Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritised DQN GPU #974

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

CasBex
Copy link
Contributor

@CasBex CasBex commented Sep 13, 2023

Fixes #973. (Has been tested with CUDA.allowscalar(false))

Two remarks

  1. Currently, k and p' are returned as CuArrays. This does not seem to hamper the algorithm so I've not reverted them back, but if that is an issue it can be changed.
  2. I have not included tests in the form of an experiment but simply modified the existing JuliaRL_PrioritizedDQN_CartPole. I can add that to the experiments but I think that it will just clutter the RLExperiments package.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #974 (38f16bb) into main (4f414c6) will increase coverage by 3.96%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            main     #974      +/-   ##
=========================================
+ Coverage   9.66%   13.62%   +3.96%     
=========================================
  Files        214      220       +6     
  Lines       7529     7601      +72     
=========================================
+ Hits         728     1036     +308     
+ Misses      6801     6565     -236     
Files Changed Coverage Δ
...LearningZoo/src/algorithms/dqns/prioritized_dqn.jl 0.00% <0.00%> (ø)

... and 63 files with indirect coverage changes

@HenriDeh
Copy link
Member

Can't do simpler than that. If it works then let's keep the send_to_device for all traces.

@HenriDeh HenriDeh merged commit d7dba9b into JuliaReinforcementLearning:main Sep 14, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prioritised DQN failing on GPU
2 participants