Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed logic of warning on dimension mismatch #4735

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yha
Copy link
Member

@yha yha commented Apr 28, 2023

Description

Fixes spurious warnings when missing/NaN is at the start or end of input vector, as in

plot([missing; 1:4], color=1:5)

Adds stricter checks with warnings in other cases. Tests pass even when these warnings are changed to errors, but I kept them as warnings to be less breaking.

warn_on_attr_dim_mismatch really shouldn't have anything to do with segments, so maybe it should be called from elsewhere in the pipeline, but I'm not sure where.

Attribution

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 78.57% and project coverage change: +0.32% 🎉

Comparison is base (349eea4) 89.96% compared to head (6c32105) 90.29%.
Report is 59 commits behind head on master.

❗ Current head 6c32105 differs from pull request most recent head 77de082. Consider uploading reports for the commit 77de082 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4735      +/-   ##
==========================================
+ Coverage   89.96%   90.29%   +0.32%     
==========================================
  Files          40       40              
  Lines        8383     8729     +346     
==========================================
+ Hits         7542     7882     +340     
- Misses        841      847       +6     
Files Changed Coverage Δ
RecipesPipeline/src/utils.jl 97.26% <ø> (+1.36%) ⬆️
src/utils.jl 92.22% <75.00%> (-0.40%) ⬇️
src/recipes.jl 84.60% <83.33%> (+0.12%) ⬆️

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants