Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI update #196

Merged
merged 32 commits into from
Oct 16, 2024
Merged

CI update #196

merged 32 commits into from
Oct 16, 2024

Conversation

boriskaus
Copy link
Collaborator

This is an attempt to get CI to pass with the current version

@boriskaus
Copy link
Collaborator Author

I'm not sure why this is failing; it works fine on my local machine (macOS aarch64)

@boriskaus
Copy link
Collaborator Author

@ViralBShah All MPI tests fail in the CI, but work fine locally. A simple "hello world" MPI test does work, so it doesn't seem to be because of MPI itself.
As far as I can tell, the correct MPICH_jll is being employed.
Any idea?

@ViralBShah
Copy link
Member

ViralBShah commented Oct 15, 2024

I have been noticing the same thing (passes locally on my mac but fails in CI). One thing is that the build complains it is built with OpenMPI but we are using MPICH. The other thing is that we are unable to use the latest MPICH.

Perhaps @eschnett can help us with MPI here?

@boriskaus
Copy link
Collaborator Author

The problem with MPICH was solved last week thanks to @vchuravy and @giordano and only occured if the PATH environmental variable was empty. As far as I can tell, we here use the working version of MPICH.

Where do you see that PETSc was build with OpenMPI? That would indeed be a problem - it should be using the MPICH build instead.

@boriskaus
Copy link
Collaborator Author

Problem solved. Turns out to be that one should add

using PETSc

at the beginning of runtests.jl...

@boriskaus
Copy link
Collaborator Author

I am deactivating CI on windows because the PETSc_jll binaries for windows were compiled without MPI support (it did compile with MicrosoftMPI, but we always get runtime errors). Perhaps someone motivated can solve this again at some stage (it did work at some point in the past), and we can allow windows again.

Until that stage, windows users can simply install WSL on their machine and run PETSc.jl though windows. This will also give access to additional external packages.

@ViralBShah
Copy link
Member

Where do you see that PETSc was build with OpenMPI? That would indeed be a problem - it should be using the MPICH build instead.

I suspect I saw that in some CI logs, which would be very hard to find. If I see it again, I'll open a new issue.

@boriskaus
Copy link
Collaborator Author

I suspect I saw that in some CI logs, which would be very hard to find. If I see it again, I'll open a new issue.

ok. It appears to be solved meanwhile, so I'll merge this PR.

@boriskaus boriskaus merged commit c414de7 into main Oct 16, 2024
6 checks passed
@boriskaus boriskaus deleted the bk/ci_update branch October 16, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants