-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Unicode 16 via utf8proc 2.10.0 #56925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Close #56035
Before closing #56035, should some of the tables in |
Yes. julia/stdlib/REPL/src/emoji_symbols.jl Lines 24 to 31 in 8e9c59f
But upstream still use Unicode 15. So maybe
|
I don't think the tables in stdlib/REPL should block this PR. Those tables are for tab completion, which is optional — most Unicode characters do not have tab completions. Just because we process/parse new Unicode emoji doesn't mean we have to have tab completions for them — those can wait. (And updating Unicode versions is about a lot more than allowing new emoji in identifiers! I mostly advertised the 7 new emoji as a joke.) |
Let's merge this and update the tables for REPL in a later pr |
Similar to #51799, support Unicode 16 by bumping utf8proc to 2.10.0 (thanks to JuliaStrings/utf8proc#277 by @eschnett).
This allows us to use 7 exciting new emoji characters as identifiers, including "face with bags under eyes"
"\U1fae9"
(but still no superscript "q").Closes #56035.