Unwrap contiguous views in copyto!
#56657
Open
+67
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
copyto!(A, B)
where both the arrays use linear indexing, if one or both the arrays are contiguous linear views, we may forward thecopyto!
to the parents. This ensures that we hit optimizedcopyto!
implementations for the parent, if any. Similarly, for the 5-argument version. In fact, in this PR, we call the 5-argument version within the 2-argumentcopyto!
if both the arrays use linear indexing.An example of a performance improvement:
In this case, we dispatch to the optimized
copyto!(::Array, ::Integer, ::Array, ::Integer, ::Integer)
method by unwrapping the view. This method usesmemmove
, which is faster than the fallback implementation that uses loops.