Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Theorem 7 in Miya14 #129

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

orkolorko
Copy link
Collaborator

PR description

Implemented Algorithm M1 based on Theorem 7 of
https://link.springer.com/article/10.1007/s13160-014-0145-5

After

The, not exported function svdbox, allows to compute rigorous enclosures of the singular values of a matrix (rectangular and square)

Checklist

  • Updated/added tests
  • Updated/added docstring (needed only for exported functions)

Other

I did not export the function yet

@lucaferranti
Copy link
Member

thank you very much! This is a very nice and welcome addition! I'll try to investigate the failing tests in the next couple of days

@orkolorko
Copy link
Collaborator Author

I'm doing some further work on the branch

@orkolorko orkolorko closed this Sep 2, 2022
@orkolorko orkolorko reopened this Sep 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Base: 97.19% // Head: 96.72% // Decreases project coverage by -0.48% ⚠️

Coverage data is based on head (17f6aae) compared to base (fe87dd4).
Patch coverage: 94.21% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   97.19%   96.72%   -0.48%     
==========================================
  Files          17       19       +2     
  Lines         642      763     +121     
==========================================
+ Hits          624      738     +114     
- Misses         18       25       +7     
Impacted Files Coverage Δ
src/IntervalLinearAlgebra.jl 73.68% <66.66%> (-26.32%) ⬇️
src/eigenvalues/miyajima_svd.jl 97.53% <97.53%> (ø)
src/multiplication.jl 100.00% <100.00%> (ø)
src/numerical_test/multithread.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@orkolorko
Copy link
Collaborator Author

orkolorko commented Sep 2, 2022

thank you very much! This is a very nice and welcome addition! I'll try to investigate the failing tests in the next couple of days

@lucaferranti I'm happy is it interesting! Happy to contribute!

I am thinking about implementing Miyajima's estimates for eigenvalues later on, also.

I will also check if Miyajima's svd estimate works for complex matrices (Rump estimate works, so it should, but the theorems in his paper are only stated for real matrices.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants