Ensure that @check always clear error stack. #186
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR is created to solve issue #185. It should also help with issue #180
Description
I have tried to make a slightly more general fix.
@check
will now handle elements inXML_GLOBAL_ERROR_STACK
also when the ccall completes as expected. These elements will be handled as warnings. This also allows us to remove theshow_warnings
from the html readers and just have it as a general part of@check
. Positive side note is that 'EzXML' now can parse XMLs with invalid xmlns.A test cases have been added to ensure that it solves the original issue.