-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D recon #324
Draft
curtcorum
wants to merge
55
commits into
JuliaHealth:master
Choose a base branch
from
curtcorum:3D_recon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
3D recon #324
Changes from 2 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
36408a2
3D_recon work in progress.
curtcorum 674c0f2
Line 123 setup_raw() needs modifications for 3D?
curtcorum d3ff944
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum 826fa5e
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum 6368e89
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum be10215
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum b1ce21c
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum a7fd74e
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum c6c9e21
Merge branch 'master' into 3D_recon
cncastillo 8eb57a9
Merge branch 'master' into 3D_recon
curtcorum f7a7c0b
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum 440402d
Doctring updated for Sequence().
curtcorum 971bca4
Fixed typo in Sequence() docstring.
curtcorum 43f01dd
Now exporting default_sim_params.
curtcorum c669ecc
Changes to signal_to_raw_data, now separate counters for z and slices.
curtcorum 032c3f2
Fixed counter calculation for nz and ns for signal_to_raw_data.
curtcorum 38fd47a
Debugging counters for signal_to_raw_data. No need to reset the scan_…
curtcorum aa37f37
Counters fixed. Needs some more testing. Ready to try 3D recon with M…
curtcorum 410c403
Fixing 2D vs 3D in progress, 2D currently broken in KomaUI()!!
curtcorum b5fc898
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum eb3e450
Still debugging...
curtcorum bbaa408
Merge branch '3D_recon' of github.com:curtcorum/KomaMRI.jl into 3D_recon
curtcorum c82a735
Still forces 2D recons someplace...???!!!
curtcorum 570bde7
Debugging reconstruction calls from KomaUI().
curtcorum 3bd4209
Debug raw data conversion for ge3d_cac.seq, something funny...!!!
curtcorum d977f25
A fair amount of work to estimate proper 3D recon parameters from seq…
curtcorum a4c387c
Update ISMRMRD.jl
curtcorum dacc56d
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum bd51a01
Update ISMRMRD.jl
curtcorum 9aac620
Update ISMRMRD.jl
curtcorum 05d862a
Update ISMRMRD.jl
curtcorum 8719f0a
Update ISMRMRD.jl
curtcorum acc981d
Update ISMRMRD.jl
curtcorum eb9b789
Debugging signal_to_raw_data
curtcorum 9f25e24
Check on Ny, Ns, Nz == 0 for scan counters.
curtcorum 26c6c1b
Defaulting to `use_ndseq=true` for `signal_to_raw_data`.
curtcorum 32b5dfd
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum 8b46d5c
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum df5aff8
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum aba7452
Merge branch 'master' into 3D_recon
curtcorum 8f3fc9f
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum 6eb7702
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum 585304f
Working on central recon parameter estimation in KomaMRICore/src/rawd…
curtcorum ffea298
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum af870bd
Working on estimate_seq_recon_dimension, working for 2d multislice, n…
curtcorum c8e76fb
Merge branch 'master' into 3D_recon
curtcorum 12e0d63
Fixing merge.
curtcorum b101fe1
Whitespace formatting.
curtcorum c98d92b
Forced type of Nx, Ny, Nz, Ns read from seq.DEF to be Int64.
curtcorum 18539d1
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum 0f317cb
LiearAlgebra added to Project. Check for radial sampling.
curtcorum 3d5c2cc
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum af4f6da
Merge branch 'master_merge' into 3D_recon_merge
curtcorum 5bcff4f
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum f393f4a
Merge branch 'JuliaHealth:master' into 3D_recon
curtcorum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -221,8 +221,8 @@ function KomaUI(; darkmode=true, frame=true, phantom_mode="2D", sim=Dict{String, | |||||
acq_data = AcquisitionData(raw_aux) | ||||||
acq_data.traj[1].circular = false #Removing circular window | ||||||
acq_data.traj[1].nodes = acq_data.traj[1].nodes[1:2,:] ./ maximum(2*abs.(acq_data.traj[1].nodes[:])) #Normalize k-space to -.5 to .5 for NUFFT | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this line is generating problems.
Suggested change
|
||||||
Nx, Ny = raw_aux.params["reconSize"][1:2] | ||||||
rec_params[:reconSize] = (Nx, Ny) | ||||||
Nx, Ny, Nz = raw_aux.params["reconSize"][1:3] | ||||||
rec_params[:reconSize] = (Nx, Ny, Nz) | ||||||
rec_params[:densityWeighting] = true | ||||||
|
||||||
# Perform reconstruction | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ci gives an error saying that
NadcsPerImage = floor(Int, Nadcs / Nz)
=>Nz = 0
. This line could be the problem.I wonder if
Δx[3]
isInf
.