Stop using deprecated signatures from Distances.jl #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
devmotion
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Good to fix those! Two main comments:
- The deprecations and in particular the new syntax was only added in Change signature of
pairwise!andcolwise!JuliaStats/Distances.jl#239, so we have to bump the Distances compat entry to 0.10.9. - We should change the function signature of
KernelFunctions.pairwise!in the same way.
|
Thanks for catching this. If you could please bump the patch version, I'm happy to approve |
devmotion
reviewed
Oct 6, 2023
|
Bump :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using a deprecated signature of
Distances.pairwise!, leading to distracting warnings.This PR fixes those.