[WIP] Replace Zygote adjoints with ChainRules' rrules #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
requested changes
Aug 13, 2020
sharanry
commented
Aug 14, 2020
src/chainrules.jl
Outdated
Comment on lines
74
to
80
| function ChainRulesCore.rrule(::typeof(ColVecs), X::AbstractMatrix) | ||
| return ColVecs(X), vecs_pullback | ||
| end | ||
|
|
||
| function ChainRulesCore.rrule(::typeof(RowVecs), X::AbstractMatrix) | ||
| return RowVecs(X), vecs_pullback | ||
| end |
There was a problem hiding this comment.
@willtebbutt How do we go about defining rrules for constructors?
For example, here typeof(ColVecs) results in UnionAll which is probably not what we want.
There was a problem hiding this comment.
Would it make sense to replace typeof(ColVecs) with Type{ColVecs}?
|
Maybe JuliaDiff/ChainRulesCore.jl#150 could simplify some definitions? |
willtebbutt
reviewed
Aug 30, 2020
| throw(error("In slow method")) | ||
| end | ||
|
|
||
| function ChainRulesCore.rrule(::Type{ColVecs}, X::AbstractMatrix) |
There was a problem hiding this comment.
I think the right thing to do here would be ::Type{<:ColVecs}, would it not?
| return ColVecs(X), vecs_pullback | ||
| end | ||
|
|
||
| function ChainRulesCore.rrule(::Type{RowVecs}, X::AbstractMatrix) |
|
Replaced by #208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#116 (comment)
Currently a lot of AD tests fail. Still need to work on revamping the AD tests to use ChainRulesTestUtils.jl.
TODO
rrule_testfor each of therrules. Plain usage of them results in errors withFiniteDifferences. Figure of if this is due to the incorrect rrules.test/utils.jlseems pass with minimal imports but fail other wise. Figure out why.