Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Zygote issues with FunctionTransform #152

Merged
merged 5 commits into from
Aug 15, 2020
Merged

Fix Zygote issues with FunctionTransform #152

merged 5 commits into from
Aug 15, 2020

Conversation

sharanry
Copy link
Contributor

#116 (comment)

The problem was due to the usage of mutating function mapslices. We now avoid using it.

@sharanry
Copy link
Contributor Author

Slightly unrelated. I was wondering if we could add efficient ways to initialize ColVecs and RowVecs from a Vector of Vectors. I feel this is a common scenario and it might be useful to implement it the right way once.

devmotion
devmotion requested changes Aug 11, 2020
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think ideally one should use mapreduce here. Can we figure out why it was slower in the benchmarks (IIRC)?

src/transform/functiontransform.jl Show resolved Hide resolved
devmotion
devmotion reviewed Aug 13, 2020
View reviewed changes
src/zygote_adjoints.jl Outdated Show resolved Hide resolved
devmotion
devmotion approved these changes Aug 15, 2020
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharanry sharanry merged commit f144045 into master Aug 15, 2020
@sharanry sharanry deleted the sharan/fix-transform-AD branch August 16, 2020 08:44
@devmotion devmotion mentioned this pull request Aug 20, 2020
Closed
@devmotion devmotion mentioned this pull request Aug 30, 2020
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion devmotion approved these changes

@theogf theogf Awaiting requested review from theogf

@willtebbutt willtebbutt Awaiting requested review from willtebbutt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharanry @devmotion