Add python_requires and relax numpy requirements
#109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `python_requires` key to the `setup.json` which will inform `pip` what minimum version of Python is supported. The upper requirement of `numpy` is removed, since `pip` should automatically prevent installing a version of `numpy` that requires a higher version of Python than is installed. Finally, the requirement for `aiida-core` is simplified by using the compatibility operator `aiida-core~=1.3` which means exactly the same as `aiida-core>=1.3,<2.0` but is more succinct and readable.
|
@broeder-j and @Tseplyaev I think these changes should fix the issue that we have in installing |
|
Superseded by #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
python_requireskey to thesetup.jsonwhich will informpipwhat minimum version of Python is supported. The upper requirementof
numpyis removed, sincepipshould automatically preventinstalling a version of
numpythat requires a higher version of Pythonthan is installed.
Finally, the requirement for
aiida-coreis simplified by using thecompatibility operator
aiida-core~=1.3which means exactly the same asaiida-core>=1.3,<2.0but is more succinct and readable.