Copy to clipboard #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josholith
reviewed
Jun 29, 2023
| this.connect('button_press_event', () => { | ||
| copyToClipboard(this.buttonText.get_text()); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This could use some logic to not copy things like "Loading..." or "" (an empty string) to the clipboard.
|
Thanks for the contribution. Ideally this branch would have been done with smaller logical commits. The one commit has both the new feature (copy to clipboard) and a JS refactor (var/let/const) and also some whitespace adjustments. With all the changes in a single commit, if there is a problem later, it is more effort to revert just part of the change (must edit files, can't use git revert). Not a show stopper, but just suggesting it for future contribs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My updated proposition to issue #2