TEST CI #30
Open
TEST CI #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilhelvaci
force-pushed
the
develop
branch
2 times, most recently
from
1185474 to
37c45b5
Compare
## Description Patch `@typescript-eslint/typescript-estree` to support node 18.12 (LTS)
closes: Agoric#9614 closes: Agoric#7012 refs: agoric-labs/xsnap-pub#49 ## Description Wire a mechanism to force rebuilds of xsnap when some build environments change, or if the xsnap binary is found to be out of date through the embedded xsnap package version. Moves the `agd build` check to depend on a version check implemented by the xsnap package, which now only depends on the package version that is dynamically inserted instead of an explicit magic string that wasn't getting updated. Agoric#7012 (comment) expressed concerns with relying on the xsnap package version, however: - any changes to `xsnap-pub` or `moddable` submodules would result in a change to the checked in `build.env` file, which would be detected by `lerna` during the publish process. While a version bump would not apply for contributors of the sdk (aka not every xsnap change results in a version change), it will apply for anyone using published versions, even if the change is in submodules only. - By having the version check look up the expected version from the `package.json` file directly, we avoid having to modify both the `package.json` file and the check itself. Only the automatically generated single publish commit will trigger a forced rebuild, and satisfy the check on its own, - At the same time we remove the dependency of `agd build` onto the the internal structure of xsnap. ### Security Considerations Forces all validators to use the expected version of xsnap ### Scaling Considerations Does a few more checks when building xsnap, and causes full rebuilds in some cases where they might not be strictly necessary. ### Documentation Considerations Should all be transparent ### Testing Considerations Manually tested by touching the xsnap package version, or reverting just the release binary to a previous copy (or deleting altogether). If the binary is meddled with like this, `agd build` checks will fail, but a manual `yarn build` will fix. I thought this was better than transparently forcing a rebuild in that abnormal situation. ### Upgrade Considerations Smoother upgrades by validators
refs: Agoric#9622 ## Description Enforce the Node.js version in agd builder. Reverts Agoric#9619 This enforces LTS range, aka `^18.12` or `^20.9` through a regexp similar to the golang version check. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations We'll need to update release notes for validators to use `agd build` instead of the former `yarn install` and `yarn build` as that may still fail. If they still chose to go that route, they're on their own. ### Testing Considerations CI covers `agd build` ### Upgrade Considerations Smooth the transition away from previously supported Node v16 in upgrade-15
refs: Agoric#9622 ## Description Agoric#9623 claimed to enforce Node.js versions ^18.12 or ^20.9, but due to a typo allows arbitrarily high versions to pass the check. This corrects it to enforce that the major version is exactly 18 or 20. ### Security Considerations None. ### Scaling Considerations n/a ### Documentation Considerations Matches the [README](https://github.com/Agoric/agoric-sdk?tab=readme-ov-file#prerequisites). ### Testing Considerations Checked by integration testing in CI. ### Upgrade Considerations Will need an update for supporting Node.js v22 when that enters LTS (ref Agoric#9265).
Co-authored-by: Michael FIG <[email protected]>
Co-authored-by: Michael FIG <[email protected]>
refs: Agoric#9308 ## Description - adds `asPromise` helper to `VowTools` for unwrapping `Vow|Promise`, ensuring proper handling of ephemeral promises - updates watch-utils to better handle values that are not storable durably, such as promises ### Testing Considerations This does not include tests that simulate an upgrade - only a heap zone is used in the included tests. See Agoric#9631 ### Upgrade Considerations This PR includes changes we'd like to be in the initial release of vows.
closes: Agoric#9572 ## Description Provides testing utilities for simulating IBC bridge events and packets in `@agoric/orchestration` .
closes: #XXXX refs: #XXXX ## Description Currently liquidation.ts only allows placing bids in the beginning of the test flow which causes conflicting offer ids if there are newer bids. In this PR we offset those bids by defining a `base` variable. cc @turadg ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations None ### Upgrade Considerations None
…e for readability (WiP) fix(liquidationVisibility): fix unit tests after rebase updates
…ty` in core-eval Refs: #35
…s` and update tests accordingly Refs: #35
…ove `writeLiqVisibility` Refs: #35
…onVisibilityWriters` resulted with below changes; * Use `Promise.all` instead of `allValuesSettled` * Remove `liq-rejected-schedule` and `liq-rejected-timestampStorageNode` as we don't need to handle those cases anymore * Write an error message in postAuction and auctionResults recorder kits in the case of an error in distributing plans Refs: #35
…lated artifacts. Refs: #35
…sibility method and respective snapshot
…o `eval-liquidation-visibility.js` Refs: #35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the CI Jorge