Fix installer.sh #313
Merged
Fix installer.sh #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@Jopyth Are you still there? |
|
Looks good. Should I make a release to fix the installer on main/master branch or is there more work ready to be merged soon-ish? |
|
@Jopyth Maybe I can continue working on the module during the holidays, but a release would be nice because this is a fix 🙂 |
|
Alright, I am going to make a release as soon as possible. Thank you very much for your contributions. I will send you an invitation as a collaborator to give you more freedom to further improve and maintain the project if you want. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MagicMirror² v2.27.0, the string has changed and the installer script was not able to detect the MagicMirror² directory.
MagicMirrorOrg/MagicMirror@v2.26.0...v2.27.0