Add JavaScript linting and GitHub workflow for testing #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm seeing a few warnings on the code, made by run-lint. |
|
We could easily fix them, but then we would have problems with merging some older pull requests. My plan was to deal with the warnings later. But we can pursue a different strategy and take care of this linter issues now. I would also agree to that 🙂 |
|
I see! I propose to merge this PR and the olders that seems worth to have. And making the next step to fix the linter. Maybe after the fix, we can plan a release, and come back with testings after it. How does that sound to you? |
|
Sounds good! 😃 |
|
Cool! I'll merge them then ✨️ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To continue tackling issue #297, I'm adding JavaScript linting and a GitHub workflow that runs the linting and spelling tests on every push and pull request.
I've deliberately set soft linting rules. If I set harder rules, the resulting code changes would certainly cause ugly merge conflicts of old pull requests.
We can make the linter rules harder after we have dealt with the old pull requests.