fix handling of max array layers per pass, fixes #5

JolifantoBambla · Jun 20, 2024 · 18f82fe · 18f82fe
1 parent afbd01b
commit 18f82fe
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [v2.0.1] - 2024-06-20
+
+### Fixed
+
+ - Fix handling of cases where a texture's number of array layers exceeds the maximum number of array layers per pass.
+
 ## [v2.0.0] - 2024-04-25
 
 ### Added

diff --git a/dist/index.js b/dist/index.js
@@ -817,7 +817,7 @@ class DevicePipelines {
             return undefined;
         }
         const passes = [];
-        for (let baseArrayLayer = 0; baseArrayLayer < this.maxArrayLayers - 1; baseArrayLayer += this.maxArrayLayers) {
+        for (let baseArrayLayer = 0; baseArrayLayer < target.depthOrArrayLayers; baseArrayLayer += this.maxArrayLayers) {
             const numArrayLayersThisPass = Math.min(target.depthOrArrayLayers - baseArrayLayer, this.maxArrayLayers);
             for (let baseMip = 0; baseMip < numMipsTotal - 1; baseMip += this.maxMipsPerPass) {
                 const numMipsThisPass = Math.min(numMipsTotal - 1 - baseMip, this.maxMipsPerPass);

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "webgpu-spd",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "A port of AMD's Single Pass Downsampler for WebGPU",
   "type": "module",
   "main": "dist/index.js",

diff --git a/src/index.ts b/src/index.ts
@@ -938,7 +938,7 @@ class DevicePipelines {
         }
 
         const passes = [];
-        for (let baseArrayLayer = 0; baseArrayLayer < this.maxArrayLayers - 1; baseArrayLayer += this.maxArrayLayers) {
+        for (let baseArrayLayer = 0; baseArrayLayer < target.depthOrArrayLayers; baseArrayLayer += this.maxArrayLayers) {
             const numArrayLayersThisPass = Math.min(target.depthOrArrayLayers - baseArrayLayer, this.maxArrayLayers);
             for (let baseMip = 0; baseMip < numMipsTotal - 1; baseMip += this.maxMipsPerPass) {
                 const numMipsThisPass = Math.min(numMipsTotal - 1 - baseMip, this.maxMipsPerPass);