Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TextTheme and dependencies for latest version of Flutter #1958

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

mdmohsin7
Copy link
Collaborator

🗃 Migrate TextTheme and dependencies for latest version of Flutter

From Flutter 3.19, the TextTheme has been deprecated (https://docs.flutter.dev/release/breaking-changes/3-19-deprecations#texttheme). Alongside that, there are packages that have been discontinued as well. Those packages are json_schema2 in favor of json_schema, local_auth_ios in favor of local_auth_darwin.

There are some miscellanious changes as well which have been recommended by the Dart Linter. For instance, in some places Container has been replaced with DecoratedBox, the new keyword has been omitted etc.,

✅ Checklist

  • Github issue details are up to date for people to QA.
  • I have tested all my changes.

🕵️‍♂️ Notes for Code Reviewer

Technical explanations to help your peers review your work - including environments, credentials, etc.

🙈 Screenshots

For all UI changes

description 1 description 2
img1 img2

👯‍♀️ Paired with

@github-handle or "nobody" if you did not pair.

Copy link
Member

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting line length 120 to fit with the code base.

lib/components/error_dialog.dart Outdated Show resolved Hide resolved
n13
n13 previously approved these changes Jun 18, 2024
Copy link
Member

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - a huge amount of work!

Approving but with the request to rename the variable as in the comment

Copy link
Member

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n13 n13 merged commit 91f3795 into JoinSEEDS:master Jun 21, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants