Fix stack overflow on self-referential __index mtv

JohnnyMorganz · Nov 23, 2022 · ff6fdf1 · ff6fdf1
1 parent 2eada2f
commit ff6fdf1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## [Unreleased]
 
+### Fixed
+
+- Fixed stack overflow when looking up properties on a table type where the `__index` is set to itself
+
 ## [1.14.0] - 2022-11-13
 
 ### Added

diff --git a/src/LuauExt.cpp b/src/LuauExt.cpp
@@ -687,7 +687,8 @@ std::optional<Luau::Property> lookupProp(const Luau::TypeId& parentType, const L
             if (indexIt != mtable->props.end())
             {
                 Luau::TypeId followed = Luau::follow(indexIt->second.type);
-                if (Luau::get<Luau::TableTypeVar>(followed) || Luau::get<Luau::MetatableTypeVar>(followed))
+                if ((Luau::get<Luau::TableTypeVar>(followed) || Luau::get<Luau::MetatableTypeVar>(followed)) &&
+                    followed != parentType) // ensure acyclic
                 {
                     return lookupProp(followed, name);
                 }