Skip to content

Commit

Permalink
Sync to upstream Luau 0.655
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnnyMorganz committed Dec 14, 2024
1 parent b84140f commit 23a1f71
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Changed

- Sync to upstream Luau 0.654
- Sync to upstream Luau 0.655

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion luau
Submodule luau updated from 8b8118 to 2e6fdd
3 changes: 2 additions & 1 deletion src/operations/SignatureHelp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ static bool checkOverloadMatch(Luau::TypePackId subTp, Luau::TypePackId superTp,
{
Luau::InternalErrorReporter iceReporter;
Luau::UnifierSharedState unifierState(&iceReporter);
Luau::SimplifierPtr simplifier = newSimplifier(Luau::NotNull{typeArena}, builtinTypes);
Luau::Normalizer normalizer{typeArena, builtinTypes, Luau::NotNull{&unifierState}};

if (FFlag::LuauSolverV2)
Expand All @@ -29,7 +30,7 @@ static bool checkOverloadMatch(Luau::TypePackId subTp, Luau::TypePackId superTp,
unifierState.counters.recursionLimit = FInt::LuauTypeInferRecursionLimit;
unifierState.counters.iterationLimit = FInt::LuauTypeInferIterationLimit;

Luau::Subtyping subtyping{builtinTypes, Luau::NotNull{typeArena}, Luau::NotNull{&normalizer}, Luau::NotNull{&typeFunctionRuntime}, Luau::NotNull{&iceReporter}};
Luau::Subtyping subtyping{builtinTypes, Luau::NotNull{typeArena}, Luau::NotNull{simplifier.get()}, Luau::NotNull{&normalizer}, Luau::NotNull{&typeFunctionRuntime}, Luau::NotNull{&iceReporter}};

// DEVIATION: the flip for superTp and subTp is expected
// subTp is our custom created type pack, with a trailing ...any
Expand Down

0 comments on commit 23a1f71

Please sign in to comment.