Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle to hide slopes in alarms #449

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

crsohr
Copy link

@crsohr crsohr commented Jul 30, 2023

This PR adds a new toggle in the Settings to opt-out of seeing slopes in alarm notifications. This setting is enabled by default (preserving the functionality of showing the slope by default).

Rationale: I am using FL2, and slopes are my main source of anxiety in the official app, as I find they are seldom accurate, and seeing “↓↓” on a “low alarm” doesn't help when it's just the sensor being sloppy and incorrect.

IMG_C9A04D22525A-1

@callms callms force-pushed the feature/show-slope-in-alarms branch 2 times, most recently from 58f43f6 to 5fbf2ed Compare December 3, 2023 14:46
@callms callms force-pushed the feature/show-slope-in-alarms branch from 5fbf2ed to a6ee96d Compare March 1, 2024 17:30
@callms callms force-pushed the feature/show-slope-in-alarms branch from a6ee96d to af6b976 Compare March 16, 2024 08:10
@paulplant paulplant changed the base branch from master to develop March 24, 2024 09:52
@paulplant
Copy link
Collaborator

Hi @crsohr , I was looking at this PR the other day and it's a tricky one to include.

The problem is that the notification should show the trend arrow. Adding yet another option which we could argue is just a "personal preference" for just one person who wants it is a bit difficult and we really try to always avoid PRs that are forcing personal preferences of just one person into the app.

I've been using a Libre 3 for the last 12 days whilst testing the heartbeat function and the L3 (via LibreLinkUp) is shockingly noisy, so I understand why the trend arrow should not be really relied upon in this case, but surely the solution should be to maybe add smoothing to the downloaded values to make them less erratic. @JohanDegraeve , what do you think?

@paulplant paulplant added the question Further information is requested label Mar 24, 2024
@callms callms force-pushed the feature/show-slope-in-alarms branch from af6b976 to 07a23e5 Compare June 8, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants