Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add param for source language #34

Merged
merged 7 commits into from
Mar 7, 2022
Merged

Conversation

resslinger
Copy link
Contributor

This PR add a breaking change to add the source language as param to translate method.

@introwit
Copy link
Member

@resslinger sorry for missing this, will be reviewing it today. Thank you ❤️

@introwit
Copy link
Member

@resslinger the PR looks good, let's drop the support for anything below Laravel v9. I will tag a major release so current installs aren't affected.

@introwit
Copy link
Member

@resslinger along with the edit requested in the above comment, can you update the readme with this new source lang feature you have added? So everyone can read and use it 😄

@steveperrycreative
Copy link

Is there anything that I can help with here to help speed up this merge? We're looking to use this with Laravel 9.

Thanks, and keep up the great work 🙂

@resslinger
Copy link
Contributor Author

I will update the readme in the next days. :)

@resslinger
Copy link
Contributor Author

@introwit I have moved the changes for Laravel 9 to a other PR.

@steveperrycreative
Copy link

Thanks @resslinger.

@introwit introwit merged commit f18d479 into JoggApp:master Mar 7, 2022
@introwit
Copy link
Member

introwit commented Mar 7, 2022

@resslinger @steveperrycreative I merged and tagged a major realise but seems like some more changes are needed to add support for Laravel 9 as seen in the test failures, which I forgot to check before merging. If anyone of you can fix them I can merge and tag asap. I will try and get myself to it as soon as I can as well. Thanks again ❤️

@introwit
Copy link
Member

@steveperrycreative support for laravel 9 was added along with this new feature but the build is failing. Created #39 to track the progress. Feel free to jump in if time allows.

@boryn
Copy link

boryn commented Mar 4, 2023

Hi @introwit and @resslinger

This change has caused that auto-detection of source language stopped working. Normally, when we do not pass 'source' in $options array to Google, the translation engine tries to detect it automatically (without an additional API call).

I introduced possibility of using empty string as the source language either explicitly at translate() / translateBatch() methods or generally in config at 'default_source_translation' at #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants