-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add param for source language #34
Conversation
@resslinger sorry for missing this, will be reviewing it today. Thank you ❤️ |
@resslinger the PR looks good, let's drop the support for anything below Laravel v9. I will tag a major release so current installs aren't affected. |
@resslinger along with the edit requested in the above comment, can you update the readme with this new source lang feature you have added? So everyone can read and use it 😄 |
Is there anything that I can help with here to help speed up this merge? We're looking to use this with Laravel 9. Thanks, and keep up the great work 🙂 |
I will update the readme in the next days. :) |
@introwit I have moved the changes for Laravel 9 to a other PR. |
Thanks @resslinger. |
@resslinger @steveperrycreative I merged and tagged a major realise but seems like some more changes are needed to add support for Laravel 9 as seen in the test failures, which I forgot to check before merging. If anyone of you can fix them I can merge and tag asap. I will try and get myself to it as soon as I can as well. Thanks again ❤️ |
@steveperrycreative support for laravel 9 was added along with this new feature but the build is failing. Created #39 to track the progress. Feel free to jump in if time allows. |
Hi @introwit and @resslinger This change has caused that auto-detection of source language stopped working. Normally, when we do not pass I introduced possibility of using empty string as the source language either explicitly at |
This PR add a breaking change to add the source language as param to translate method.