Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the method addIconFontDescriptor in Iconify.java to the following and used directly:
and using like this will be better, I delete the unnecessary class IconifyInitializer
now using like following which I think better:
Iconify.addIconFontDescriptors(
new FontAwesomeModule(),
new EntypoModule(),
new MaterialModule(),
new MaterialCommunityModule());
I also change another place in ParsingUtil to following, and I create the TypefaceSpanCache.java
text.setSpan(TypefaceSpanCache.getFaceSpan(icon,
iconFontDescriptor.getTypeface(context),
iconSizePx, iconSizeRatio, iconColor, spin, baselineAligned),
startIndex, startIndex + 1,
Spanned.SPAN_INCLUSIVE_EXCLUSIVE);
This can prevent many duplicate new CustomTypefaceSpan instance, as I debug when I screen down the screen it will duplicatedly new CustomTypefaceSpan, It's better to store faceSpan in memery.
package com.joanzapata.iconify.internal;
import android.graphics.Typeface;
import com.joanzapata.iconify.Icon;
import java.util.HashMap;
/**
Created by zhangziwei on 1/7/16.
This class is used to store the same icon TypefaceSpanCache instance in memory,
otherwise the instance will be renew many times when we scroll the screen
*/
public class TypefaceSpanCache {
private static HashMap<String, CustomTypefaceSpan> faceSpans = new HashMap<String, CustomTypefaceSpan>();
public static CustomTypefaceSpan getFaceSpan(Icon icon, Typeface type,
float iconSizePx, float iconSizeRatio, int iconColor,
boolean rotate, boolean baselineAligned) {
}
}