Add pulsing spin animation #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Font Awesome CSS framework has a pulse animation that rotates an icon in 8 steps, which matches the structure of it's pulsing spinner. This has been implemented with the "pulse" token here. Since Font Awesome seems to have the only dotted pulsing spinner out of the current font set, this seems a reasonable generic implementation at the moment. If at some point spinners with different pulses need to be handled, then a pulse property can be introduced for the icons, with 8 as the default count.
|
Note that I have a few pull requests open at the moment, and they all somewhat affect each other. My develop branch can be consulted (and used) in merging multiple of these pull requests, as I have merged all of them these with appropriate summary in the merge commit messages. Alternatively, if you merge them one at a time, then I'll rebase the others to the merged state. |
|
please merge this feature. It helps to make Apps that are consistent between Web and Android. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Font Awesome CSS framework has a pulse animation that rotates an icon in 8 steps, which matches the structure of it's pulsing spinner. This has been implemented with the "pulse" token here. Since Font Awesome seems to have the only dotted pulsing spinner out of the current font set, this seems a reasonable generic implementation at the moment. If at some point spinners with different pulses need to be handled, then a pulse property can be introduced for the icons, with 8 as the default count.