Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race with sub-fores #232

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix race with sub-fores #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ui/fx-control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,9 +446,12 @@ export default class FxControl extends XfAbstractControl {
'model-construct-done',
e => {
const defaultInst = imported.querySelector('fx-instance');
if (this.initialNode) {
if (this.initial) {
const doc = new DOMParser().parseFromString('<data></data>', 'application/xml');
// Note: Clone the input to prevent the inner fore from editing the outer node
// Also update the `initialNode` to make sure we have an up-to-date version
this.initialNode = evaluateXPathToFirstNode(this.initial, this.nodeset, this);

doc.firstElementChild.appendChild(this.initialNode.cloneNode(true));
defaultInst.setInstanceData(doc);
}
Expand Down
Loading