Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move outline-pwa to outline-web-wrapper #347

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: move outline-pwa to outline-web-wrapper #347

merged 1 commit into from
Dec 20, 2024

Conversation

daniellacosse
Copy link
Contributor

No description provided.

@daniellacosse daniellacosse merged commit 6e3e411 into main Dec 20, 2024
4 of 6 checks passed
@daniellacosse daniellacosse deleted the daniellacosse/move_pwa_to_web_wrapper branch December 20, 2024 20:30
@fortuna
Copy link
Contributor

fortuna commented Dec 20, 2024

outline- is redundant. This is in the Outline repo.
Perhaps web-wrapper? web-to-app? web-app-wrapper?

@sbruens
Copy link
Contributor

sbruens commented Dec 20, 2024

outline- is redundant. This is in the Outline repo. Perhaps web-wrapper? web-to-app? web-app-wrapper?

If we don't want that redundancy, may want to do the same to the other outline- prefixed folders: outline-cli and outline-connectivity-app, though for the cli the prefix doesn't feel as redundant.

@daniellacosse
Copy link
Contributor Author

outline- is redundant. This is in the Outline repo. Perhaps web-wrapper? web-to-app? web-app-wrapper?

If we don't want that redundancy, may want to do the same to the other outline- prefixed folders: outline-cli and outline-connectivity-app, though for the cli the prefix doesn't feel as redundant.

#348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbruens sbruens sbruens approved these changes

@fortuna fortuna Awaiting requested review from fortuna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniellacosse @fortuna @sbruens