Basic code lab for outline-web-wrapper process #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added steps to apply Kotlin plugin and update SDK versions in Gradle files. - Clarified dependency management to ensure dependencies are moved from the generated file to avoid reset issues. Without these updates, the Android setup instructions were incomplete and led to build issues.
fortuna
reviewed
Dec 13, 2024
fortuna
reviewed
Dec 16, 2024
fortuna
requested changes
Dec 16, 2024
Co-authored-by: Vinicius Fortuna <[email protected]>
Co-authored-by: Vinicius Fortuna <[email protected]>
…om/Jigsaw-Code/outline-internal-sdk into daniellacosse/initial_pwa_code_lab
sbruens
approved these changes
Dec 19, 2024
daniellacosse
changed the title
sbruens
approved these changes
Dec 20, 2024
fortuna
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved the
outline-pwatooutline-web-wrapperand updated the instructions here: https://github.com/Jigsaw-Code/outline-sdk/blob/5ac1619938828d5528bd735c2e2d70332e54e295/x/examples/outline-web-wrapper/README.md