Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client/ios): move fetching logic from TypeScript to Go #2222

Merged
merged 13 commits into from
Nov 16, 2024

Conversation

jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Sep 28, 2024

New Fetch Error

image

Prerequisite: #2220, #2221

@jyyi1 jyyi1 added the do not merge Do not merge the pull request for now. label Sep 28, 2024
@jyyi1 jyyi1 force-pushed the junyi/fetch-in-go-android branch from f9bf4d8 to b033c7b Compare October 22, 2024 21:55
@jyyi1 jyyi1 force-pushed the junyi/fetch-in-go-apple branch from 21e546c to bb7962c Compare October 22, 2024 23:58
@jyyi1 jyyi1 marked this pull request as ready for review October 23, 2024 02:01
@jyyi1 jyyi1 requested review from a team as code owners October 23, 2024 02:01
@jyyi1 jyyi1 requested review from fortuna and sbruens October 23, 2024 02:02
client/src/cordova/plugin/apple/src/OutlinePlugin.swift Outdated Show resolved Hide resolved
client/src/www/app/main.cordova.ts Show resolved Hide resolved
@jyyi1 jyyi1 force-pushed the junyi/fetch-in-go-android branch from 6a0b588 to 96a64e9 Compare November 1, 2024 23:15
Base automatically changed from junyi/fetch-in-go-android to master November 4, 2024 18:44
@jyyi1 jyyi1 force-pushed the junyi/fetch-in-go-apple branch from 72041da to 77b3766 Compare November 4, 2024 19:57
@github-actions github-actions bot added size/S and removed size/XS labels Nov 4, 2024
@jyyi1 jyyi1 requested a review from fortuna November 4, 2024 20:25
@jyyi1
Copy link
Contributor Author

jyyi1 commented Nov 4, 2024

@fortuna I rebased this branch onto master, take another look?

@jyyi1 jyyi1 removed the do not merge Do not merge the pull request for now. label Nov 15, 2024
@jyyi1 jyyi1 merged commit 4f62943 into master Nov 16, 2024
22 checks passed
@jyyi1 jyyi1 deleted the junyi/fetch-in-go-apple branch November 16, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants