Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager): smoke test the package action #2007

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented May 7, 2024

It's not much - but this would run the Linux package action in the CI. There's no signing step in the Linux package action, so we wouldn't be exposing secrets to Github, and we'd at least be able to feel comfortable that the mechanics of the package action are still working. Whether or not we're using the right certificates will have to be tested manually or by some other process.

@daniellacosse daniellacosse changed the title feat(server_manager): smoke test the package action feat(manager): smoke test the package action May 7, 2024
@daniellacosse daniellacosse marked this pull request as ready for review July 23, 2024 14:48
@daniellacosse daniellacosse requested a review from a team as a code owner July 23, 2024 14:48
@daniellacosse daniellacosse requested review from fortuna and sbruens July 23, 2024 14:48
Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is mostly to catch errors in the package workflow?

@daniellacosse daniellacosse merged commit 4f604fd into master Jul 23, 2024
24 checks passed
@daniellacosse daniellacosse deleted the daniellacosse/smoke_test_manager_package branch July 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants