Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/electron/windows): double quote full path of OutlineService #1918

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

Himura2la
Copy link
Contributor

@Himura2la Himura2la commented Mar 6, 2024

Double quote the path of OutlineService.exe in Windows service installation script to prevent a potential vulnerability discovered by a user's internal scanner below; in addition, this will also allow us to add arguments to the service command in the future.

References

Unquoted Search Path or Element is vulnerable:

Unquoted Search Path or Element is vulnerable
https://cwe.mitre.org/data/definitions/428.html
@Himura2la Himura2la requested a review from a team as a code owner March 6, 2024 09:10
@fortuna fortuna requested a review from jyyi1 March 6, 2024 15:47
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32%. Comparing base (dc02d9e) to head (c2392ef).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1918   +/-   ##
======================================
  Coverage      32%     32%           
======================================
  Files          45      45           
  Lines        2610    2610           
  Branches      337     337           
======================================
  Hits          859     859           
  Misses       1751    1751           
Flag Coverage Δ
apple 15% <ø> (ø)
ios 15% <ø> (ø)
maccatalyst 15% <ø> (ø)
macos 15% <ø> (ø)
unittests 32% <ø> (ø)
www 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jyyi1 jyyi1 changed the title Eliminate CWE-428 fix(client/electron/windows): double quote full path of OutlineService Mar 7, 2024
@jyyi1 jyyi1 merged commit 2501ca3 into Jigsaw-Code:master Mar 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants