-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cordova/apple/ios): remove overlapping dependencies between main app and AppKit bridge targets #1788
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1788 +/- ##
======================================
Coverage 32% 32%
======================================
Files 45 45
Lines 2609 2609
Branches 337 337
======================================
Hits 859 859
Misses 1750 1750
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
works without launcher.
f95e6b1
to
96b33c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks ok. It's unfortunate we need to move files into the rsync directory, but we gotta do what we gotta do. The subproject approach should clean that up a bit.
One question: what's up with all the localization files being added?
Agreed. After your subproject change I can take a stab at moving some of the stuff out of the SPM and move this over as well so we don't need to rsync these.
They are being moved (note: not added) out of SPM along with the Swift modules that depend on them. |
This is a fix/workaround for #1784.
I moved the bridge to an interface and out of SPM. I also removed the duplicate dependencies
CocoaLumberjack
andAppKitBridgeProtocol
. The latter has been replaced with anNSObject
extension.