Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): change style to filled fields to stay consistent with other text fields #1751

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Oct 10, 2023

Also made some minor other edits based on design review.

Form
Issue wizard

Also updating the server rename dialog to use a Material Design compliant text field.
Server rename dialog

@sbruens sbruens force-pushed the sbruens/form-fields branch from b54b5a8 to 7577fd6 Compare October 24, 2023 20:25
@sbruens sbruens marked this pull request as ready for review October 24, 2023 20:26
@sbruens sbruens requested a review from a team as a code owner October 24, 2023 20:26
@fortuna fortuna requested a review from daniellacosse October 24, 2023 20:34
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/www/views/contact_view/index.ts 96% <100%> (+<1%) ⬆️
src/www/views/contact_view/support_form/index.ts 88% <100%> (-1%) ⬇️
src/www/ui_components/server-rename-dialog.js 8% <0%> (ø)

📢 Thoughts on this report? Let us know!.

@sbruens sbruens requested a review from daniellacosse October 25, 2023 16:49
@sbruens sbruens merged commit b1c8491 into master Oct 25, 2023
17 checks passed
@sbruens sbruens deleted the sbruens/form-fields branch October 25, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants