Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): reset the contact view if the user navigates back #1737

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Oct 2, 2023

Currently, the state remains even if the user clicks the back button, which is managed by the parent AppRoot element. This means that if they were sent to a help center article and then open the contact view in a subsequent navigation, they can't get to the original wizard to get help for a new issue.

@sbruens sbruens requested a review from a team as a code owner October 2, 2023 20:07
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/www/views/contact_view/index.ts 96% <100%> (ø)
src/www/ui_components/app-root.js 4% <0%> (-1%) ⬇️

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep this is what happens. when you do state like this.

src/www/ui_components/app-root.js Outdated Show resolved Hide resolved
@sbruens sbruens force-pushed the sbruens/issuetype-variants branch from 281ba14 to 4d6f73c Compare October 2, 2023 22:04
@sbruens sbruens force-pushed the sbruens/contact-exit-fix branch from 4c039fc to da9d0ae Compare October 2, 2023 22:04
@sbruens sbruens force-pushed the sbruens/issuetype-variants branch from 4d6f73c to a8baa75 Compare October 4, 2023 15:57
@sbruens sbruens force-pushed the sbruens/contact-exit-fix branch 2 times, most recently from 1e3edc6 to 2056c07 Compare October 4, 2023 16:00
@sbruens sbruens force-pushed the sbruens/issuetype-variants branch from 428e0d9 to 86acd73 Compare October 4, 2023 16:08
@sbruens sbruens force-pushed the sbruens/contact-exit-fix branch from 9064028 to 3e9ec00 Compare October 4, 2023 16:12
@sbruens sbruens changed the base branch from sbruens/issuetype-variants to master October 4, 2023 16:12
@sbruens sbruens merged commit 64cf473 into master Oct 4, 2023
17 checks passed
@sbruens sbruens deleted the sbruens/contact-exit-fix branch October 4, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants