feat(www): change which issue types are shown in new contact view based on the variant #1736

sbruens · 2023-10-02T14:43:10Z

No description provided.

codecov · 2023-10-02T20:04:53Z

Codecov Report

All modified lines are covered by tests ✅

Files	Coverage Δ
src/www/views/contact_view/index.ts	`96% <100%> (ø)`
src/www/views/contact_view/issue_type.ts	`100% <ø> (ø)`

📢 Thoughts on this report? Let us know!.

sbruens requested a review from a team as a code owner October 2, 2023 14:43

github-actions bot added the size/XS label Oct 2, 2023

sbruens force-pushed the sbruens/localize-contact-view branch from b5d3c2a to aa6f61d Compare October 2, 2023 16:57

sbruens force-pushed the sbruens/issuetype-variants branch from 5f3e79b to e92f890 Compare October 2, 2023 17:00

sbruens force-pushed the sbruens/localize-contact-view branch from aa6f61d to ecd985a Compare October 2, 2023 17:01

sbruens force-pushed the sbruens/issuetype-variants branch 3 times, most recently from 9c67529 to 281ba14 Compare October 2, 2023 20:00

github-actions bot added size/S and removed size/XS labels Oct 2, 2023

sbruens force-pushed the sbruens/issuetype-variants branch from 281ba14 to 4d6f73c Compare October 2, 2023 22:04

daniellacosse approved these changes Oct 4, 2023

View reviewed changes

sbruens force-pushed the sbruens/localize-contact-view branch from d420b8c to ca4522e Compare October 4, 2023 15:47

sbruens force-pushed the sbruens/issuetype-variants branch from 4d6f73c to a8baa75 Compare October 4, 2023 15:57

github-actions bot added the missing translations label Oct 4, 2023

Base automatically changed from sbruens/localize-contact-view to master October 4, 2023 16:07

sbruens added 5 commits October 4, 2023 12:08

Change which issue types are shown based on the variant.

a5fdec0

Remove debug logs.

c727668

Add test cases for the issue type list.

2cfc297

Refactor tests to separate different behaviors.

fd1c231

Remove unused message from original messages file.

86acd73

sbruens force-pushed the sbruens/issuetype-variants branch from 428e0d9 to 86acd73 Compare October 4, 2023 16:08

sbruens merged commit c462098 into master Oct 4, 2023
16 of 17 checks passed

sbruens deleted the sbruens/issuetype-variants branch October 4, 2023 16:15