Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): localize new contact view #1735

Merged
merged 14 commits into from
Oct 4, 2023
Merged

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Oct 2, 2023

No description provided.

@sbruens sbruens requested a review from a team as a code owner October 2, 2023 14:41
@github-actions github-actions bot added the size/M label Oct 2, 2023
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits/thoughts

src/infrastructure/i18n.ts Outdated Show resolved Hide resolved
@@ -14,17 +14,11 @@
limitations under the License.
*/

import {FormattableMessage, LocalizeFunc} from 'src/infrastructure/i18n';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use import type!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, though I've never fully understood why this is better when importing TS code, since the compiler automatically identifies imports that are only used as types. I thought in this particular case it has no real effect?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just explicit to the developer IMO. And there are so MANY ways to compile in JS (tsc, babel, swc, esbuild) it's hard to guarantee what a given compiler is doing

src/www/views/contact_view/index.ts Outdated Show resolved Hide resolved
src/www/views/contact_view/stories.ts Show resolved Hide resolved
src/www/views/contact_view/index.ts Outdated Show resolved Hide resolved
@sbruens sbruens force-pushed the sbruens/localize-contact-view branch from b5d3c2a to aa6f61d Compare October 2, 2023 16:57
@sbruens sbruens force-pushed the sbruens/send-feedback branch from 18c0b17 to 8f14ff4 Compare October 2, 2023 17:01
@sbruens sbruens force-pushed the sbruens/localize-contact-view branch from aa6f61d to ecd985a Compare October 2, 2023 17:01
@github-actions github-actions bot added size/L and removed size/M labels Oct 2, 2023
@sbruens
Copy link
Contributor Author

sbruens commented Oct 2, 2023

FYI moved the .storybook/localize.ts to a different location so it can be re-used by tests that rely on localization.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/www/app/app.ts 8% <100%> (ø)
src/www/testing/localize.ts 93% <100%> (ø)
src/www/ui_components/app-root.js 4% <ø> (ø)
src/www/views/contact_view/issue_type.ts 100% <100%> (ø)
src/www/views/servers_view/server_list/index.ts 61% <ø> (ø)
...c/www/views/servers_view/server_list_item/index.ts 100% <100%> (ø)
...servers_view/server_list_item/server_card/index.ts 42% <100%> (ø)
src/www/views/contact_view/index.ts 96% <88%> (+3%) ⬆️
src/www/views/contact_view/support_form/index.ts 88% <88%> (+<1%) ⬆️

📢 Thoughts on this report? Let us know!.

Base automatically changed from sbruens/send-feedback to master October 4, 2023 15:41
@sbruens sbruens force-pushed the sbruens/localize-contact-view branch from d420b8c to ca4522e Compare October 4, 2023 15:47
@sbruens sbruens merged commit 17fdb52 into master Oct 4, 2023
17 checks passed
@sbruens sbruens deleted the sbruens/localize-contact-view branch October 4, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants