Skip to content

Commit

Permalink
Resolve code review comment round 1
Browse files Browse the repository at this point in the history
  • Loading branch information
jyyi1 committed Dec 6, 2024
1 parent 47bf530 commit a9746be
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions client/electron/debian/after_install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,6 @@ set -eux
# > The SUID sandbox helper binary was found, but is not configured correctly.
# > Rather than run without sandboxing I'm aborting now. You need to make sure
# > that /opt/Outline/chrome-sandbox is owned by root and has mode 4755.
#
# https://github.com/electron/electron/issues/42510
/usr/bin/chmod 4755 /opt/Outline/chrome-sandbox
4 changes: 2 additions & 2 deletions client/electron/vpn_service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
} from '../src/www/app/outline_server_repository/vpn';

// TODO: Separate this config into LinuxVpnConfig and WindowsVpnConfig. Some fields may share.
interface VpnConfig {
interface EstablishVpnConfig {
id: string;
interfaceName: string;
connectionName: string;
Expand All @@ -37,7 +37,7 @@ export async function establishVpn(request: StartRequestJson) {
currentRequestId = request.id;
statusCb?.(currentRequestId, TunnelStatus.RECONNECTING);

const config: VpnConfig = {
const config: EstablishVpnConfig = {
id: currentRequestId,

// TUN device name, compatible with old code:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:build !linux

package outline

import "errors"
Expand Down

0 comments on commit a9746be

Please sign in to comment.