Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [MariaDB] Support RETURNING clause #2330

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

devgor88
Copy link
Contributor

@devgor88 devgor88 commented Dec 9, 2024

Description

Summary of the change: Returning clause was implemented for MariaDB

Detailed description:


Type of Change

Please mark the relevant options with an "X":

  • Bug fix
  • New feature
  • Documentation update

Updates/remove existing public API methods:

  • Is breaking change

Affected databases:

  • MariaDB
  • Mysql5
  • Mysql8
  • Oracle
  • Postgres
  • SqlServer
  • H2
  • SQLite

Checklist

  • Unit tests are in place
  • The build is green (including the Detekt check)
  • All public methods affected by my PR has up to date API docs
  • Documentation for my change is up to date

Related Issues

@bog-walk bog-walk self-assigned this Dec 9, 2024
@bog-walk bog-walk self-requested a review December 9, 2024 13:24
@bog-walk bog-walk changed the title feat: implement returning clause for MariaDB feat: [MariaDB] Support RETURNING clause Dec 9, 2024
Copy link
Member

@bog-walk bog-walk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for opening this PR @devgor88 !

Please check the comments regarding the tests and please also update the existing documentation, specifically this docs file.
In that file, please add MariaDB to the "Supported on" section in the relevant <tldr> element (line 406). Then we'd need to add a small note about the update restriction, so please also edit the following <p> to clarify the support:

<p>Some databases allow the return of additional data every time a row is either inserted, updated, or deleted.
    Please note that MariaDB only allows the return of this data for insertions and deletions.
    This can be accomplished by using one of the following functions:
</p>

If you need any further clarification or help with these requested changes, don't hesitate to let me know. Thanks in advance!

@devgor88
Copy link
Contributor Author

devgor88 commented Dec 9, 2024

Thank you for reviewing this PR. I'm glad to be a one of contributors of this great library. I've done everything you asked for. Hope I haven't broken docs file as I'm not fully understand its format.

@devgor88 devgor88 requested a review from bog-walk December 9, 2024 20:25
Copy link
Member

@bog-walk bog-walk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 Thanks again @devgor88 & for your support of the library! Don't hesitate to contribute again or to open a discussion in YouTrack with any ideas about how our MariaDB support could be improved.

By the way, no worries about the docs, they're not broken. If you ever want to contribute more to the documentation in the future, the Writerside plugin could be helpful as it offers a live preview in the IDE for any changes.

@bog-walk bog-walk requested a review from e5l December 10, 2024 00:37
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, lgtm

@bog-walk bog-walk merged commit aaa219b into JetBrains:main Dec 10, 2024
3 checks passed
@devgor88 devgor88 deleted the returning-clause2 branch January 2, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants