Historical crypto_list based on web_snapshots at cmc #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…napshot facility of CMC. Needs srape_hist()
… the coin retrieval e.g. gathered using a custom version of rypto_list().
…adapt much more tidyverse-notation.
…adapt much more tidyverse-notation.
…scraper_hist(). Output additional information on scraped data as attribute of crypto_history() (for backward compatibility). Merge branch 'master' of https://github.com/sstoeckl/crypto # Conflicts: # R/crypto_history.R
…scraper_hist(). Output additional information on scraped data as attribute of crypto_history() (for backward compatibility). Merge branch 'master' of https://github.com/sstoeckl/crypto # Conflicts: # R/crypto_history.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I had the problem that the crypto_list function does not get all the "dead" coins that ceased existing which are important for research purposes to avoid survivorship bias. This data ia available on CMC as historic snapshot https://coinmarketcap.com/historical/20150505/ but has to be web-scraped. I have therefore created a scrape_hist function and given the coin_list function the possibility to merge periodical snapshots retrieved via the scrape_hist() function.
It is not well programmed and might need some tweaking from you but still adds an important feature to your package! I hope you find it suitable.
Best, Sebastian
P.S. The api is upposed to have such a functionality as of Q1 2019 but does not allow me access via the free tier.