Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran black formatter #55

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Ran black formatter #55

merged 1 commit into from
Nov 25, 2024

Conversation

sgoldenCS
Copy link
Contributor

Updates 30 files for formatting purposes.

All unit tests run without issue (except numpy_minmax_scaler which requires some sort of input file??? This is possibly a bug that should be fixed in a different issue...)

This completes the first objective in the issue it is linked to.

Updates 30 files for formatting purposes.
@sgoldenCS sgoldenCS self-assigned this Nov 18, 2024
@sgoldenCS sgoldenCS linked an issue Nov 18, 2024 that may be closed by this pull request
@sgoldenCS
Copy link
Contributor Author

I've double checked, and the numpy_minmax_scaler unit test also fails in the main branch so it's not an issue caused by black.

@dlersch
Copy link
Contributor

dlersch commented Nov 18, 2024

This is odd. when I tested the numpy_min_max scaler, it passed... I will look into this as well

@sgoldenCS
Copy link
Contributor Author

I made an issue (#56) for the numpy_minmax_scaler so we can deal with that separately.

@ahmedmohammed107
Copy link
Contributor

Should I leave the merge for @dlersch, or should I merge it myself?

@dlersch dlersch merged commit 7ee1654 into main Nov 25, 2024
@dlersch
Copy link
Contributor

dlersch commented Nov 25, 2024

Should I leave the merge for @dlersch, or should I merge it myself?

Merged. Good work and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running Black as a Code Formatter
3 participants