Mass and momentum smearing, moller vertices, analysis config updates #199
Conversation
…mentum smearing to vertex object...i think correctly...
…ect. Add in mollers to vertex ana processor. Fix bug in inariant mass smearing
…hat, and confirmed it gives the correct moller mass after smearing. Also updated track smearing to modify the track object saved to the particle, so the smearing persists
| { | ||
| "corrections": { | ||
| "track_time": -5.5, | ||
| "track_cluster_dt": -0.7, |
There was a problem hiding this comment.
As far as I can tell, this correction is never applied anywhere.
- This JSON is loaded into
tbc_configs_ tbc_configs_is copied intotrackBiasCorrections_Track::applyCorrectionsis used for all entries intrackBiasCorrections_but that function only does anything with"track_time"and"track_z0"and ignores everything else- Neither
tbc_configs_nortrackBiasCorrections_are referenced anywhere else
Perhaps not applying this correction is okay? I don't expect a sub-ns shift in the difference between the cluster and track times to significantly affect the cutflow, but - for confusion purposes - it'd be better to know if it should be applied.
Co-authored-by: Tom Eichlersmith <[email protected]>
Co-authored-by: Tom Eichlersmith <[email protected]>
…r cleaning since I was at it...even though its messy, sorry
…rack persist. Since there are some small track bias corrections in the ana processor, these were being applied in preselection, the track was permantently updated, then they were applied again at the other selection stages. So I moved this ele->setTrack outside of TrackSmearingTool, and removed the duplicate track bias corrections
| //After all modifications to the track are made, update the memory address that the particle gets the track from | ||
| //with the modified track, that way changes here persist throughout this processor |
There was a problem hiding this comment.
Just to be clear, the Particle holds a copy of the Track and CalCluster associated with it.
This is important to emphasize since the ele_trk and ele.getTrack() could evolve differently if only one is edited.
| smearing_histo_top_ = (TH1D*) smearingfile_->Get((tracks+"_p_vs_nHits_hh_smearing"+hsuffix+"_top").c_str()); | ||
| smearing_histo_bot_ = (TH1D*) smearingfile_->Get((tracks+"_p_vs_nHits_hh_smearing"+hsuffix+"_bot").c_str()); |
There was a problem hiding this comment.
This makes the old smearing file unusable right? I think we should either remove the old one or have the smearing tool support a file like the old one where the top and bottom are not separate.
There was a problem hiding this comment.
yeah good point, I don't think there's a reason to keep the old file around
I've added the p smearing seed flag to the analysis config.
I added invariant mass smearing directly to the vertex object invariant mass.
*THE SMEARING IS STILL NOT APPLIED CORRECTLY IN THE CUTFLOW
**The analysis selection is broken into three stages. Smearing is applied in each stage, because the tracks do not persist
**between each stage. But there are momentum cuts in preselection. So this results in events being smeared in
**momentum AFTER momentum cuts have been applied. Need to fix this...
I added in a way to process moller vertices in the NewVertexAnaProcessor.
I've made some changes to the analysis configuration script that I use for simps. It mostly involves changes to the way various track/cluster corrections are applied. They can now be loaded in from a json file.
The newest version of hps-java master adds the bfieldY at SvtCenter into TrackData. I had to update the code that checks the TrackData object structure so that it allows for that additional float index.