Iss89: Trident and WAB track rates/shapes and track efficiency #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and histo classes...need to pull in master and separate into separate issues
…nsequence were made
cbravo135
reviewed
Sep 21, 2023
processors/config/baseConfig.py
Outdated
| @@ -22,7 +22,7 @@ | |||
| help="Which analysis is being run ", metavar="analysis", default="vertex") | |||
| parser.add_argument('--infile', '-i', type=str, dest="inFilename", metavar='infiles', nargs="+", | |||
| help="Input files, specify on or more.") | |||
|
|
|||
| parser.add_argument('--runnumber', '-r', type=int, dest="runNumber",default=-666) | |||
There was a problem hiding this comment.
option r is used already in various config files, so this will clash when those are used. Can you add this locally to the config files you need it in directly?
…ers hit for tracks and v0s; makes TDirectories for plots split by layers hit; just a checkpoint, not for real use as I will move to the new style, slim tuples next before I push
|
@bloodyyugo Could you please address @cbravo135 comment so we can move on and close this PR? |
|
Should be good to go now |
|
Thank you @bloodyyugo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: rates & shapes use separate processor (TridentWABAnaProcessor) from track efficiency (TrackEfficiencyProcessor)