Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to mask dead channels when reading in HDDM/REST events #846

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

sdobbs
Copy link
Contributor

@sdobbs sdobbs commented Oct 22, 2024

This is mainly for random hits that are merged in, when the bad channel mask was updated after the random trigger files were created

Addresses issue #810

This is mainly for random hits that are merged in, when the bad channel mask was updated after the random trigger files were created
@jrstevenjlab
Copy link
Contributor

@lihaoahil, could you confirm this addresses one of the issues you've observed in the energy dependence of the reconstruction efficiency?

And is my understanding correct that this will need to be ported to the recon compatible analysis versions for previous run periods?

Copy link
Contributor

@lihaoahil lihaoahil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new feature has been tested successfully after rebased to 4.51.0 (for detail see here).

@lihaoahil lihaoahil merged commit c24d021 into master Oct 24, 2024
@lihaoahil
Copy link
Contributor

@sdobbs I believe this is need to be ported to the Recon-launch-compatible versions for previous run periods to get more accurate reconstruction efficiency?

@sdobbs
Copy link
Contributor Author

sdobbs commented Oct 24, 2024

yes, but I didn't want to start the work until it was merged with the main branch. putting this on my list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants