Fix EOF Crash in JANA2 Event Sources (#834) #836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the crash occurring at the end of REST file processing in JANA2 event sources, as detailed in issue #834. The root cause was the outdated exception handling mechanism inherited from JANA1, where reaching the end of a file would throw an exception to indicate that all events had been processed. In case of JANA1, it was getting perceived as a signal of no more events if exception thrown was RETURN_STATUS::kNO_MORE_EVENTS but no more in JANA2 that's why it was not crashing with JANA1 but now in JANA2 it is. Ideally also it's not good to throw any kind of exception just to end things. That's why JANA2 introduced an
Emit
function that returns Result enums properly indicating end instead of throwing exception approach.Key Changes:
Testing:
Impact:
Fixes: