Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set TAGH energy based on current geometry #764

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

sdobbs
Copy link
Contributor

@sdobbs sdobbs commented Nov 13, 2023

Should fix issue #763

Copy link
Contributor

@staylorjlab staylorjlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The continues on lines 654 and 715 lead to memory leaks if they are called. The DBeamPhoton* gamma = new DBeamPhoton();
lines should be moved after these lines.

@aaust aaust requested a review from jrstevenjlab November 29, 2023 21:14
@sdobbs
Copy link
Contributor Author

sdobbs commented Nov 30, 2023

Thanks for the catch, Simon - that should be fixed now.

@aaust aaust removed the request for review from jrstevenjlab December 1, 2023 00:09
Copy link
Contributor

@aaust aaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@aaust aaust merged commit 7f6cd30 into master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants