Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add final job, to be required as a trunk branch protection rule #127

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Oct 9, 2023

Github branch protection rules for a job matrix status check require every matrix element to be set to "required". This PR adds a simple downstream job, named final, which will only run successfully if all tests pass.

@baltzell: with this PR, the development branch protection rule may be set to require just the final status check to pass

@c-dilks
Copy link
Member Author

c-dilks commented Oct 9, 2023

After some testing, I find that a skipped/cancelled job is not really considered a failure, according to branch protection rules, so the conditionals here in final force it to always run and only succeed or fail; cancellation will cause its failure.

@c-dilks c-dilks marked this pull request as ready for review October 9, 2023 22:03
@baltzell baltzell merged commit 6bed8d2 into JeffersonLab:development Oct 12, 2023
9 of 10 checks passed
@c-dilks c-dilks deleted the summary branch October 13, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants