Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dispatch clas12-validation workflow runs #126

Merged
merged 1 commit into from
Oct 9, 2023
Merged

ci: dispatch clas12-validation workflow runs #126

merged 1 commit into from
Oct 9, 2023

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Oct 6, 2023

Adds a workflow to dispatch clas12-validation workflow runs.

Since this is a PR from a fork, the PAT is not accessible and the dispatch job will fail until this PR is merged.

To see an example working dispatch, see this equivalent PR against my fork, along with a successful workflow dispatch run; follow the "Workflow URL" link in the run's summary table to see the dispatched clas12-validation run.


Unfortunately, a PR from a fork will never* have a successful validation dispatch, because of the inaccessible PAT; one possible workaround is having a contributor from a fork open a test PR on clas12-validation, manually changing the default coatjava fork and branch here, but that's not ideal.

*well.. unless we use the dangerous pull_request_target trigger, which might be okay as long as we require approvals for running workflows for PRs from forks. IIRC the only secret we have is the PAT for clas12-validation dispatches, but if we enable pull_request_target, we need to be very careful if we forget about this and add another secret, especially if such a secret grants write access somewhere.

@c-dilks c-dilks marked this pull request as ready for review October 7, 2023 00:29
@c-dilks
Copy link
Member Author

c-dilks commented Oct 9, 2023

Note: this uses my fork of trigger-workflow-and-wait so that we may use convictional/trigger-workflow-and-wait#90

@baltzell baltzell merged commit 3af0200 into JeffersonLab:development Oct 9, 2023
8 of 9 checks passed
@c-dilks c-dilks deleted the trigger-validation branch October 9, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants