Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition with refactor #194

Merged
merged 25 commits into from
Oct 2, 2024
Merged

Composition with refactor #194

merged 25 commits into from
Oct 2, 2024

Conversation

OscarMrZ
Copy link
Collaborator

@OscarMrZ OscarMrZ commented Sep 17, 2024

Expands on the work done in #188 (this is a branch from there), rebasing it with the changes of #190

@OscarMrZ OscarMrZ mentioned this pull request Sep 24, 2024
@OscarMrZ OscarMrZ force-pushed the composition-with-refactor branch from a597fac to 83941b7 Compare September 30, 2024 14:11
@OscarMrZ OscarMrZ force-pushed the composition-with-refactor branch from 5d2b1dc to becbfcd Compare October 1, 2024 15:55
@javizqh
Copy link
Collaborator

javizqh commented Oct 1, 2024

Is this ready to be merged?

@OscarMrZ
Copy link
Collaborator Author

OscarMrZ commented Oct 2, 2024

Yeah it is!

@javizqh javizqh linked an issue Oct 2, 2024 that may be closed by this pull request
@javizqh javizqh merged commit ffe41bf into main Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom universe launch broken on refactoring
2 participants