Fix visit command

JaySunSyn · Apr 25, 2019 · 2101b10 · 2101b10
1 parent 178513a
commit 2101b10
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -13,6 +13,9 @@ import 'cypress-daywalker/commands'
 ```
 
 ## Usage
+
+The daywalker script gets injected when visiting a page via `cy.visit()`.
+
 [Example](https://github.com/JaySunSyn/cypress-daywalker/blob/master/example/cypress/integration/example.spec.js)
 
 Some custom commands:
@@ -25,4 +28,4 @@ cy.get('paper-button').dispatch(new MouseEvent('click'))
 
 cy.get('paper-input').setProp('moto moto')
 cy.get('paper-input').setProp('Question', 'label')
-```
+```
diff --git a/commands.js b/commands.js
@@ -247,20 +247,19 @@ Cypress.Commands.overwrite('should', (...args) => {
     return attachAndReturnOriginalFn(...args);
 });
 
-Cypress.Commands.overwrite('visit', (...args) => {
+Cypress.Commands.overwrite('visit', (originalFn, url, options, nodeModulesBase = '/node_modules/') => {
   Cypress.log({
     displayName: 'DAYWALKER VISIT',
-    message: ${args[1]},
+    message: url,
    });
 
   cy.on('window:before:load', (w) => {
     const script = w.document.createElement('script');
-    script.src = '/node_modules/cypress-daywalker/cypress-daywalker.js';
+    script.src = `${nodeModulesBase}cypress-daywalker/cypress-daywalker.js`;
     w.document.querySelector('head').appendChild(script);
   });
 
-  const originalFn = args.shift();
-  return originalFn(...args);
+  return originalFn(url, options);
 });
 
 Cypress.Commands.add('setProp', { prevSubject: true }, (subject, value, prop = 'value') => {

diff --git a/cypress-daywalker.js b/cypress-daywalker.js
@@ -122,7 +122,6 @@
         .filter(element => {
           const parent = element.parentNode;
           const classList = (parent.classList && Array.from(parent.classList)) || [];
-
           if (parentSelectorType.id) {
             return parent.id === parentSelectorType.id;
           }

diff --git a/example/index.html b/example/index.html
@@ -5,7 +5,6 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <meta http-equiv="X-UA-Compatible" content="ie=edge">
     <title>Daywalker</title>
-    <script src="./node_modules/cypress-daywalker/cypress-daywalker.js"></script>
     <script type="module" src="src/my-element.js"></script>
 </head>
 <body>