reset matches when testing an empty UA

Make sure, getMatches will not return stale data if the last test was performed for an empty UA or only consists of excluded patterns.
JayBizzle · May 30, 2024 · f0f29f5 · f0f29f5
1 parent e9f5cdd
commit f0f29f5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/CrawlerDetect.php b/src/CrawlerDetect.php
@@ -169,6 +169,7 @@ public function isCrawler($userAgent = null)
         ));
 
         if ($agent === '') {
+            $this->matches = array();
             return false;
         }
 

diff --git a/tests/UserAgentTest.php b/tests/UserAgentTest.php
@@ -129,6 +129,16 @@ public function matches_does_not_persit_across_multiple_calls()
         $this->CrawlerDetect->isCrawler('This should not match');
         $matches = $this->CrawlerDetect->getMatches();
         $this->assertNull($this->CrawlerDetect->getMatches());
+
+        //Empty
+        $this->CrawlerDetect->isCrawler('Mozilla/5.0 (iPhone; CPU iPhone OS 7_1 like Mac OS X) AppleWebKit (KHTML, like Gecko) Mobile (compatible; Yahoo Ad monitoring; https://help.yahoo.com/kb/yahoo-ad-monitoring-SLN24857.html)');
+        $this->CrawlerDetect->isCrawler('');
+        $this->assertNull($this->CrawlerDetect->getMatches());
+
+        //Excluded
+        $this->CrawlerDetect->isCrawler('Mozilla/5.0 (iPhone; CPU iPhone OS 7_1 like Mac OS X) AppleWebKit (KHTML, like Gecko) Mobile (compatible; Yahoo Ad monitoring; https://help.yahoo.com/kb/yahoo-ad-monitoring-SLN24857.html)');
+        $this->CrawlerDetect->isCrawler('iPod');
+        $this->assertNull($this->CrawlerDetect->getMatches());
     }
 
     /** @test */
-Original file line number
+Diff line change
@@ Expand Up / @@ -169,6 +169,7 @@ public function isCrawler($userAgent = null) @@
             ));
             if ($agent === '') {
+                $this->matches = array();
                 return false;
             }
@@ Expand Down @@